replace string enum usage with dart enums #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
victortive
commented
Sep 26, 2024
victortive
commented
- Usage of strings for the direction is confusing and inconsistent as one place uppercased the call direction.
- To make the API easier to use, I have replaced the direction with an enum
victortive
changed the title
make sure the session terminates
cloudwebrtc
approved these changes
Dec 2, 2024
|
I'll look into resolving this |
victortive
force-pushed
the
call-direction-enum
branch
from
01c00e4 to
f0d8461
Compare
|
@mikaelwills You can probably merge this PR first and I'll fix the rest of them since this is the large number of files changed |
|
@victortive ah, just merged the other one. This one still has conflicts, follow all the git steps I mentioned in the other PR |
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.